Use dynamic attributes in factories #3622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
changed the title
microweb10
approved these changes
Jun 23, 2019
javierm
force-pushed
the
use_dynamic_factories
branch
from
bb19225
to
20b4672
Compare
javierm
force-pushed
the
use_dynamic_factories
branch
2 times, most recently
from
2c85114
to
2640d50
Compare
These rules are now defined under `Style/`. However, we don't really use them, so they add noise to the rubocop configuration file without solving any issues we actually have.
Factory bot has stopped supporting dynamic attributes, and we'll have to change all factories before upgrading. In order to apply the rubocop rule, we need to bump rubocop-rspec to its latest version.
Static attributes are deprecated since factory bot 4.11; we haven't upgraded yet but now we're ready to do so: https://thoughtbot.com/blog/deprecating-static-attributes-in-factory_bot-4-11
The reason for this rule is similar to dynamic factories: we want dynamic dates to be evaluted relative to the current time, and not relative to the moment the application was loaded.
javierm
force-pushed
the
use_dynamic_factories
branch
from
2640d50
to
c2869f4
Compare
|
Travis failure is not related to this pull request. |
javierm
added
Refactoring
Linters
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…ries Use dynamic attributes in factories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives