Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ruby to 2.4.6 #3627

Merged
merged 4 commits into from
Oct 12, 2019
Merged

Upgrade Ruby to 2.4.6 #3627

merged 4 commits into from
Oct 12, 2019

Conversation

javierm
Copy link
Member

@javierm javierm commented Jun 22, 2019

Background

Many gems have dropped support for Ruby 2.3, including Rails 6, which is going to be released soon.

Objectives

  • Upgrade Ruby to a more recent and well supported version

@javierm javierm self-assigned this Jun 22, 2019
@javierm
Copy link
Member Author

javierm commented Jun 24, 2019

Travis failure is not related to this pull request.

@javierm javierm changed the title Upgrade ruby to 2.4.6 [WIP] Upgrade ruby to 2.4.6 Jun 27, 2019
@javierm javierm changed the base branch from remove_capistrano_tasks to master June 27, 2019 19:11
@javierm javierm changed the title [WIP] Upgrade ruby to 2.4.6 Upgrade ruby to 2.4.6 Jul 2, 2019
@javierm javierm force-pushed the upgrade_to_ruby2.4 branch 12 times, most recently from 9312dda to f7de1d2 Compare July 4, 2019 15:35
@javierm javierm force-pushed the upgrade_to_ruby2.4 branch 2 times, most recently from 0fae1cf to ede87ff Compare August 7, 2019 22:11
@javierm javierm added this to Doing in Roadmap Sep 10, 2019
@javierm javierm assigned microweb10 and unassigned javierm Sep 10, 2019
@javierm javierm changed the base branch from master to puma October 9, 2019 19:43
@javierm javierm self-assigned this Oct 9, 2019
@javierm javierm moved this from Doing to Testing in Roadmap Oct 9, 2019
@javierm javierm changed the base branch from puma to master October 12, 2019 21:52
We're going to upgrade our ruby version, and we need these tasks.

Note we now get a warning caused by `rvm1:install:ruby` invoking
`deploy:updating`. It doesn't seem to be an issue because we don't add
any hooks to `deploy:updating`, and neither do the rest of the gems we
use.
Travis and Rubocop and rmv1-capistrano3 automatically detect the version
based on the `.ruby-version` file.
We use `:rvm` just as we use `:rake` in other places.
Many gems have dropped support for Ruby 2.3, including Rails 6.

We've already tested the upgrade on production environments; no issues
so far.
@javierm javierm merged commit 970c323 into master Oct 12, 2019
Roadmap automation moved this from Testing to Release 1.1.0 Oct 12, 2019
@javierm javierm deleted the upgrade_to_ruby2.4 branch October 12, 2019 23:00
@javierm javierm changed the title Upgrade ruby to 2.4.6 Upgrade Ruby to 2.4.6 Oct 13, 2019
@javierm javierm mentioned this pull request Oct 21, 2019
smarques pushed a commit to venetochevogliamo/consul that referenced this pull request Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Roadmap
  
Release 1.1.0
Development

Successfully merging this pull request may close these issues.

None yet

2 participants