-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Ruby to 2.4.6 #3627
Merged
Merged
Upgrade Ruby to 2.4.6 #3627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
upgrade_to_ruby2.4
branch
from
June 24, 2019 15:28
cb19bb9
to
5237e37
Compare
Travis failure is not related to this pull request. |
javierm
force-pushed
the
upgrade_to_ruby2.4
branch
from
July 2, 2019 11:51
5237e37
to
38115b7
Compare
javierm
force-pushed
the
upgrade_to_ruby2.4
branch
12 times, most recently
from
July 4, 2019 15:35
9312dda
to
f7de1d2
Compare
microweb10
approved these changes
Jul 4, 2019
javierm
force-pushed
the
upgrade_to_ruby2.4
branch
2 times, most recently
from
August 7, 2019 22:11
0fae1cf
to
ede87ff
Compare
javierm
force-pushed
the
upgrade_to_ruby2.4
branch
from
September 10, 2019 20:33
ede87ff
to
496f626
Compare
javierm
force-pushed
the
upgrade_to_ruby2.4
branch
from
September 11, 2019 13:36
496f626
to
bc52935
Compare
javierm
force-pushed
the
upgrade_to_ruby2.4
branch
from
October 9, 2019 19:43
bc52935
to
a3b726d
Compare
javierm
force-pushed
the
puma
branch
9 times, most recently
from
October 12, 2019 15:01
5d97745
to
f26f8b3
Compare
javierm
force-pushed
the
upgrade_to_ruby2.4
branch
from
October 12, 2019 22:02
a3b726d
to
9e1eb69
Compare
We're going to upgrade our ruby version, and we need these tasks. Note we now get a warning caused by `rvm1:install:ruby` invoking `deploy:updating`. It doesn't seem to be an issue because we don't add any hooks to `deploy:updating`, and neither do the rest of the gems we use.
Travis and Rubocop and rmv1-capistrano3 automatically detect the version based on the `.ruby-version` file.
We use `:rvm` just as we use `:rake` in other places.
Many gems have dropped support for Ruby 2.3, including Rails 6. We've already tested the upgrade on production environments; no issues so far.
javierm
force-pushed
the
upgrade_to_ruby2.4
branch
from
October 12, 2019 22:32
9e1eb69
to
a8331c9
Compare
This was referenced Oct 13, 2019
Merged
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Upgrade ruby to 2.4.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Many gems have dropped support for Ruby 2.3, including Rails 6, which is going to be released soon.
Objectives