Fix typos and remove unused code #3630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voodoorai2000
approved these changes
Jun 24, 2019
javierm
force-pushed
the
fix_typos
branch
2 times, most recently
from
13cfdac
to
19a0656
Compare
javierm
force-pushed
the
fix_typos
branch
2 times, most recently
from
b2969cc
to
4e3dfbb
Compare
The interpolation was being evaluated as a comment.
This method was not used since commit d024505.
The statement executed the method twice if the `present?` condition was true. If the condition was false, it executed it once anyway. It's probably a typo and originally we probably meant we wanted to execute the method if the method existed.
This file was probably generated automatically and we forgot to remove it. We never use it; the edit action includes its own form.
The label text was always in English, and it wasn't associated with any
input field.
The `SecureRandom` part is a quick hack so we don't get duplicate IDs.
Using "your_answer_#{question.id}" might work as well, but right now I'm
not sure if the form is sometimes rendered twice for the same question.
I've also renamed the key for the settings title so the `<h1>` gets the `title` key, as done in other sections in the admin.
The typo was detected thanks to erb-lint SpaceInHtmlTag rule.
The name of this file should be `settings_helper.rb` (which already exists), and the method `setting_for_widget` was never used anywhere.
|
Travis failures are not related to this pull request, but due to network timeouts probably when connecting to map and translations services. |
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Fix typos and remove unused code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives