Remove code specific to Internet Explorer 8 #3649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
remove_ie8_code
branch
2 times, most recently
from
cbff046
to
4eebd05
Compare
Internet Explorer 9 was released eight years ago. Besides that, we don't really support IE8 anyway, since we show a popup to IE8 users saying we don't support it, we haven't maintained the IE8-specific CSS file for years, and we don't test our JavaScript against IE8.
javierm
force-pushed
the
remove_ie8_code
branch
from
4eebd05
to
738e9eb
Compare
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Remove code specific to Internet Explorer 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We don't support IE8: we show a popup to IE8 users saying we don't support it, we haven't maintained the IE8-specific CSS file for years, and we use ECMAScript 5 code which doesn't work in IE8.
However, we've still got some (unmaintained) code only loaded for IE8.
Objectives
Remove code giving the false impression that CONSUL works with Internet Explorer 8.