Remove unused JavaScript code #3652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
remove_unused_javascript
branch
2 times, most recently
from
05e5789
to
5167622
Compare
houndci-bot
reviewed
Jul 2, 2019
javierm
force-pushed
the
remove_unused_javascript
branch
from
5167622
to
6dd720b
Compare
javierm
force-pushed
the
remove_unused_javascript
branch
from
6dd720b
to
bd96ea9
Compare
javierm
force-pushed
the
remove_unused_javascript
branch
from
8491ce4
to
b45d178
Compare
|
Travis failure is not related to this pull request. |
javierm
force-pushed
the
remove_unused_javascript
branch
from
b45d178
to
a23c224
Compare
houndci-bot
reviewed
Jul 7, 2019
| @@ -21,10 +21,8 @@ App.WatchFormChanges = | |||
| if App.WatchFormChanges.forms().length == 0 || App.WatchFormChanges.msg() == undefined | |||
| return | |||
|
|
|||
| $(document).off("page:before-change").on("page:before-change", (e) -> App.WatchFormChanges.checkChanges(e)) | |||
| $(document).off("page:before-change").on("page:before-change", -> App.WatchFormChanges.checkChanges()) | |||
There was a problem hiding this comment.
Line exceeds maximum allowed length. Length is 106, max is 100.
javierm
force-pushed
the
remove_ie8_code
branch
from
742f488
to
cbff046
Compare
javierm
force-pushed
the
remove_unused_javascript
branch
from
a23c224
to
fa1baa3
Compare
javierm
force-pushed
the
remove_ie8_code
branch
from
cbff046
to
4eebd05
Compare
javierm
force-pushed
the
remove_ie8_code
branch
from
4eebd05
to
738e9eb
Compare
javierm
force-pushed
the
remove_unused_javascript
branch
from
fa1baa3
to
0ab8fc7
Compare
javierm
force-pushed
the
remove_unused_javascript
branch
from
0ab8fc7
to
d8efa18
Compare
We don't load the token message since commit 585f9ea, so the JavaScript to show it wasn't doing anything anymore.
The banner `update_style` method isn't used since commit 82cb8d4.
The `initialize` functions don't need to return anything, since their returned value is never used. Returning false is a common practice in jQuery to stop an event, but in plain JavaScript methods it doesn't have any side effects.
This code isn't used since commit 54e59a8.
The `removeCookie` function is never called, and the `initialize` function doesn't do anything. The only functions we use here are `getCookie` and `saveCookie`.
This code requires the variable `_paq` to be set somewhere, but we never set it. In the past Decide Madrid added some custom JavaScript using this code. However, in CONSUL we're using Ahoy to track events, and we don't have any documentation about adding custom JavaScript to use piwik nor we've got any other piwik integration.
javierm
force-pushed
the
remove_unused_javascript
branch
from
d8efa18
to
e4985d3
Compare
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…ascript Remove unused JavaScript code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives