Fix text confirming investment heading support #3656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis build failed because of the issue fixed by #3641, so the failure is not related to this pull request. |
javierm
force-pushed
the
fix_alert_text
branch
3 times, most recently
from
18f7b42
to
efd3a76
Compare
We accidentally removed the `count` option in commit 55fb14a, which made the translation return a hash. The test is a bit hacky, which makes me think changing the user interface would probably be a better solution.
javierm
force-pushed
the
fix_alert_text
branch
from
efd3a76
to
2f10005
Compare
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Fix text confirming investment heading support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We accidentally removed the
countoption in the confirm group text in commit 55fb14a, which made the translation return a hash.Visual Changes
Before this change:
After this change: