Remove duplicate translation classes #3674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We accidentally added them twice when rebasing the translations branch.
We're moving the code for the phases translation class to the same place in the code the other translation classes are: right after including the Globalizable module.
javierm
force-pushed
the
remove_duplicate_translation_classes
branch
from
489ba52
to
e500d15
Compare
|
Travis failure was caused by network issues in Travis and is not related to this pull request. |
notapatch
pushed a commit
to notapatch/consul
that referenced
this pull request
Aug 13, 2019
…translation_classes Remove duplicate translation classes
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…translation_classes Remove duplicate translation classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
Remove code we accidentally duplicated when merging the translations branch into the master branch.