Evaluate mailer from address at runtime

[javierm]

References

• Failures on Travis build 31267, job 2

Background

We're reading the value from the database, but the ApplicationMailer.default method is evaluated when the application is started. So if we don't use a Proc, we'll need to restart the server every time we change the value in the database, or else the old value will still be used.

Objectives

Make sure emails are sent using the from address currently defined in the database.

Notes

Before these changes, the following tests failed locally if executed right after running rake db:test:prepare, because the default from: was being evaluated before seeding the test database.

  1) Dashboards Rake #send_notifications Send notifications to proposal author when there are news actions actived for draft proposals
     Failure/Error: expect(email).to deliver_from("CONSUL <noreply@consul.dev>")

     NoMethodError:
       undefined method `addrs' for #<Mail::UnstructuredField:0x00562f174330e0>
     # ./spec/lib/tasks/dashboards_spec.rb:80:in `block (4 levels) in <top (required)>'

  2) Dashboards Rake #send_notifications Send notifications to proposal author  when there are news actions actived for published proposals
     Failure/Error: expect(email).to deliver_from("CONSUL <noreply@consul.dev>")

     NoMethodError:
       undefined method `addrs' for #<Mail::UnstructuredField:0x00562f0f85c250>
     # ./spec/lib/tasks/dashboards_spec.rb:67:in `block (4 levels) in <top (required)>'

  3) Dashboard::Mailer#new_actions_notification rake task #new_actions_notification_rake_published sends emails when detect new actions for proposal
     Failure/Error: expect(email).to deliver_from("CONSUL <noreply@consul.dev>")

     NoMethodError:
       undefined method `addrs' for #<Mail::UnstructuredField:0x007fd676f2c250>
     # ./spec/mailers/dashboard/mailer_spec.rb:125:in `block (4 levels) in <top (required)>'

  4) Dashboard::Mailer#new_actions_notification rake task #new_actions_notification_rake_created sends emails when detect new actions for draft proposal
     Failure/Error: expect(email).to deliver_from("CONSUL <noreply@consul.dev>")

     NoMethodError:
       undefined method `addrs' for #<Mail::UnstructuredField:0x00562f1bdc1068>
     # ./spec/mailers/dashboard/mailer_spec.rb:83:in `block (4 levels) in <top (required)>'

  5) Dashboard::Mailer#new_actions_notification_on_create sends emails if new actions detected when creating a proposal
     Failure/Error: expect(email).to deliver_from("CONSUL <noreply@consul.dev>")

     NoMethodError:
       undefined method `addrs' for #<Mail::UnstructuredField:0x007fd677494800>
     # ./spec/mailers/dashboard/mailer_spec.rb:181:in `block (3 levels) in <top (required)>'

  6) Dashboard::Mailer#new_actions_notification_on_published sends emails when detect new actions when publish a proposal
     Failure/Error: expect(email).to deliver_from("CONSUL <noreply@consul.dev>")

     NoMethodError:
       undefined method `addrs' for #<Mail::UnstructuredField:0x00562f1bef7040>
     # ./spec/mailers/dashboard/mailer_spec.rb:247:in `block (3 levels) in <top (required)>'

  7) Dashboard::Mailer#forward sends forward email
     Failure/Error: expect(email).to deliver_from("CONSUL <noreply@consul.dev>")

     NoMethodError:
       undefined method `addrs' for #<Mail::UnstructuredField:0x007fd6756b02d0>
     # ./spec/mailers/dashboard/mailer_spec.rb:40:in `block (3 levels) in <top (required)>'