Reduce the number of proposals in pagination spec #3687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
reduce_proposals_in_pagination
branch
2 times, most recently
from
cc53d73
to
ab17282
Compare
We're getting a failure on Travis in one of these tests. Debugging shows the AJAX request rendering the first page (after clicking the "Previous" link) takes too long and sometimes it exceeds Capybara's timeout. After running the test thousands of times, the only way I've found to clearly reduce the number of times the test fails is to reduce the number of records shown on the first page. Other experiments, like adding an `includes(:author)` to the query getting the proposals in the controller, or adding `author: user` to the `create_list` part of the test (so only one author needs to be fetched when rendering the proposals) show inconsistent results regarding performance. Note we still need at least 10 proposals for the test for several users, to guarantee two users will never get the same records during the test (or at least the probability they get the same records is one in millions).
javierm
force-pushed
the
reduce_proposals_in_pagination
branch
from
ab17282
to
1c071b5
Compare
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…in_pagination Reduce the number of proposals in pagination spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Background
We're getting a failure on Travis in one of these tests. Debugging shows the AJAX request rendering the first page (after clicking the "Previous" link) takes too long and sometimes it exceeds Capybara's timeout.
Objectives
Make the test faster so we don't reach Capybara's timeout.
Notes
After running the test thousands of times, the only way I've found to clearly reduce the number of times the test fails (reducing the time of the request by 0.4 seconds on average) is to reduce the number of records shown on the first page. Other experiments, like adding an
includes(:author)to the query getting the proposals in the controller, or addingauthor: userto thecreate_listpart of the test (so only one author needs to be fetched when rendering the proposals) show inconsistent results regarding performance.Of course improving the performance of the partial rendering legislation proposals would be a better solution. However, after some debugging I wasn't able to find a clear bottleneck, so speeding up this part would be a complex task.
The test failed with the following message: