Remove redundant code #3719
Merged
Remove redundant code #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since two records cannot have the same key, having a scope that will always return just one record is the same as using `find_by_key`.
The factory creating assignments automatically assigns a poll to it, so we don't use the poll for anything else, there's no need to explicitely create it.
The factories creating proposals and debates automatically create an author.
One test was testing regular users can't access results, and another one was testing neither regular users nor managers can. So the second test can just test the admin scenario, and we're still covering everything.
This data was added in commit 62088bc, but the changes in that commit don't seem to be related to the number of questions in a poll.
Questions are automatically created by the poll_question_answer factory.
houndci-bot
reviewed
Sep 24, 2019
| @@ -434,8 +434,7 @@ | |||
|
|
|||
| scenario "Display links to vote on groups with no investments voted yet" do | |||
| group = create(:budget_group, budget: budget) | |||
| heading = create(:budget_heading, name: "District 1", group: group, price: 100) | |||
|
|
|||
| heading = create(:budget_heading, group: group, price: 100) | |||
There was a problem hiding this comment.
Lint/UselessAssignment: Useless assignment to variable - heading. (https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars)
There was a problem hiding this comment.
Thanks! Will remove it in a different pull request.
The "name" attribute is automatically generated by the budget heading factory. And the "price" attribute is out of context and not needed since this test doesn't create investments.
javierm
force-pushed
the
remove_redundant_code
branch
from
61dbed0
to
01862d6
Compare
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…code Remove redundant code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
I18nContentmodel