Update featured proposals specs #3720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a case where we created 5 extra records in pagination and checked 2 records were present, because the other 3 were automatically considered featured proposals. Explicitely creating featured proposals let us create 2 extra records and check 2 records are present, which is far more intuitive.
Before we disabled featured proposals by default, there were many tests creating them because they were needed in order to create non-featured proposals. But now these tests don't need to create featured proposals anymore.
These specs were added before we disabled featured proposals by default. After that, they were passing, but they were not testing the scenario they were supposed to test.
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…s_specs Update featured proposals specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Update tests managing featured proposals, since their behaviour changed when we disabled featured propsals by default.