Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify creating associations in specs #3732

Merged
merged 14 commits into from
Sep 30, 2019
Merged

Simplify creating associations in specs #3732

merged 14 commits into from
Sep 30, 2019

Conversation

javierm
Copy link
Member

@javierm javierm commented Sep 26, 2019

Objectives

  • Make tests easier to read
  • Reduce the number of useless assignment warnings given by the Ruby interpreter

@javierm javierm added the Specs label Sep 26, 2019
@javierm javierm self-assigned this Sep 26, 2019
@javierm javierm added this to Reviewing in Roadmap via automation Sep 26, 2019
houndci-bot
houndci-bot reviewed Sep 26, 2019
View reviewed changes
spec/models/proposal_spec.rb Outdated Show resolved Hide resolved
spec/models/proposal_spec.rb Outdated Show resolved Hide resolved
spec/models/proposal_spec.rb Outdated Show resolved Hide resolved
spec/models/proposal_spec.rb Outdated Show resolved Hide resolved
spec/models/budget/investment_spec.rb Show resolved Hide resolved
spec/lib/graphql_spec.rb Show resolved Hide resolved
spec/lib/graphql_spec.rb Show resolved Hide resolved
spec/lib/graphql_spec.rb Show resolved Hide resolved
spec/lib/graphql_spec.rb Show resolved Hide resolved
spec/features/budgets/investments_spec.rb Show resolved Hide resolved
@javierm javierm force-pushed the voters_in_specs branch 2 times, most recently from 4ada00c to c7b4099 Compare September 26, 2019 20:51
houndci-bot
houndci-bot reviewed Sep 26, 2019
View reviewed changes
spec/features/budgets/ballots_spec.rb Outdated Show resolved Hide resolved
spec/models/budget/investment_spec.rb Outdated Show resolved Hide resolved
spec/models/budget/investment_spec.rb Outdated Show resolved Hide resolved
@javierm javierm changed the title Simplify creating voters and followers in specs Simplify creating voters, balloters and followers in specs Sep 26, 2019
@javierm javierm changed the title Simplify creating voters, balloters and followers in specs Simplify creating vote, ballots and follows in specs Sep 26, 2019
@javierm javierm force-pushed the voters_in_specs branch 2 times, most recently from bbf2fe7 to a48bada Compare September 27, 2019 00:56
@javierm javierm changed the title Simplify creating vote, ballots and follows in specs Simplify creating votes, ballots and follows in specs Sep 27, 2019
@javierm javierm changed the title Simplify creating votes, ballots and follows in specs Simplify creating associations in specs Sep 27, 2019
houndci-bot
houndci-bot reviewed Sep 27, 2019
View reviewed changes
spec/models/budget/investment_spec.rb Show resolved Hide resolved
spec/models/budget/investment_spec.rb Show resolved Hide resolved
spec/models/budget/investment_spec.rb Show resolved Hide resolved
spec/models/budget/investment_spec.rb Show resolved Hide resolved
spec/models/budget/investment_spec.rb Show resolved Hide resolved
spec/features/budgets/investments_spec.rb Show resolved Hide resolved
@javierm javierm force-pushed the voters_in_specs branch 2 times, most recently from e439845 to 27d0322 Compare September 27, 2019 23:26
houndci-bot
houndci-bot reviewed Sep 28, 2019
View reviewed changes
spec/lib/email_digests_spec.rb Show resolved Hide resolved
spec/lib/email_digests_spec.rb Show resolved Hide resolved
spec/lib/email_digests_spec.rb Show resolved Hide resolved
@javierm javierm force-pushed the array_specs branch 3 times, most recently from f9255d2 to c2d7420 Compare September 29, 2019 21:57
@javierm javierm changed the base branch from array_specs to master September 29, 2019 22:37
@javierm
Simplify creating follows in specs
5ff1162 
While in theory we wouldn't need to use the `transient` nor the
`after(:create)` because there's already a `has_many :through`
association with followers, Factory Bot / ActiveRecord don't
automatically associate the followable, resulting in an invalid record
exception.
@javierm
Simplify creating ballot lines in specs
71c24f8
@javierm
Simplify assigning a name to an officer
c6acc70
@javierm
Simplify creating officer assignments in specs
b431273 
Note we usually cannot make it simple because officer assignments are
usually assigned to both a poll and a booth, and on a certain date.
However, in the few cases where the booth nor the date don't matter, we
can make the code a bit easier to read.
@javierm
Use final trait for poll officer assignments
bd73c5f 
We were only using it in a few places.

I've left the current `final: true` statement in a few places where
using a trait would break vertical alignment, just in case.
@javierm
Simplify creating a topic with a community
11723fb
@javierm
Simplify creating videos for a poll in specs
f535d81
@javierm
Simplify creating notifications in specs
1973c61
@javierm
Use traits instead of methods to create headings
c15b58f
@javierm
Simplify assigning booth to a voter
19edf04 
Unless we're using the booth assignment for something else in the test,
when creating a voter from booth, specifying the poll and the booth is
enough to create a booth assignment.
@javierm
Simplify creating images with title for milestones
c34ebc9
@javierm
Simplify adding investments to ballots in specs
e2b536e
@javierm javierm merged commit 59e3e32 into master Sep 30, 2019
Roadmap automation moved this from Reviewing to Release 1.1.0 Sep 30, 2019
@javierm javierm deleted the voters_in_specs branch September 30, 2019 12:38
smarques pushed a commit to venetochevogliamo/consul that referenced this pull request Apr 29, 2020
@javierm
Merge pull request consuldemocracy#3732 from consul/voters_in_specs
a75d359 
Simplify creating  associations in specs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

Assignees

@javierm javierm

Labels
Specs
Projects
No open projects
Roadmap
  
Release 1.1.0
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@javierm @houndci-bot