Add rubocop lint rules #3735
Merged
Add rubocop lint rules #3735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
remove_unused_variables
branch
from
a32a7e8
to
17dd30b
Compare
javierm
force-pushed
the
rubocop_lint
branch
from
b7d0395
to
5531e3b
Compare
javierm
force-pushed
the
remove_unused_variables
branch
from
17dd30b
to
994b580
Compare
javierm
force-pushed
the
rubocop_lint
branch
from
5531e3b
to
b3d47d2
Compare
javierm
force-pushed
the
remove_unused_variables
branch
from
994b580
to
306e7d2
Compare
javierm
force-pushed
the
rubocop_lint
branch
from
b3d47d2
to
54e7ed6
Compare
javierm
force-pushed
the
remove_unused_variables
branch
from
306e7d2
to
33af62d
Compare
javierm
force-pushed
the
rubocop_lint
branch
from
54e7ed6
to
29c87f0
Compare
javierm
force-pushed
the
remove_unused_variables
branch
from
33af62d
to
06a61b0
Compare
javierm
force-pushed
the
rubocop_lint
branch
from
e30654e
to
78a8edf
Compare
javierm
force-pushed
the
remove_unused_variables
branch
from
06a61b0
to
d8ce75a
Compare
javierm
force-pushed
the
rubocop_lint
branch
2 times, most recently
from
e077d1b
to
9781876
Compare
javierm
changed the base branch from
remove_unused_variables
to
rspec_instance_variables
javierm
force-pushed
the
rubocop_lint
branch
from
9781876
to
f1bd779
Compare
javierm
force-pushed
the
rspec_instance_variables
branch
5 times, most recently
from
cec060e
to
4de4045
Compare
javierm
changed the base branch from
rspec_instance_variables
to
rubocop_fixes
javierm
force-pushed
the
rubocop_lint
branch
from
f1bd779
to
37b0a01
Compare
javierm
force-pushed
the
rubocop_fixes
branch
5 times, most recently
from
50290d9
to
545f161
Compare
Naming two variables the same way is confusing at the very least, and can lead to hard to debug errors. That's why the Ruby interpreter issues a warning when we do so.
This is a very subtle behaviour: `match /attachment/i` could represent a regular expression, but it could also represent a division like `match / attachment / i`. So we need to make an exception to the usual way we omit parenthesis in RSpec expectations.
We're using `yield` in the method body.
These methods were defined with `attr_reader` (or accessor in some cases) and then they were redefined.
There are more cases where we have unused block arguments, but I'm only changing the obvious ones.
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Add rubocop lint rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The Ruby interpreter issues warnings on code having patterns which could easily result in bugs. Rubocop has rules to detect all those warnings and some more.
Objectives
Notes
There's one Ruby warning I haven't fixed: the autoload trigger in
PollsController. We'll have to investigate whether the issue loading classes is still present after upgrading to Rails 5.There are also several rubocop rules I haven't added; they either give false positives, or are a bit overkill.