Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in legacy code #3750

Merged
merged 3 commits into from
Oct 8, 2019
Merged

Fix typos in legacy code #3750

merged 3 commits into from
Oct 8, 2019

Conversation

javierm
Copy link
Member

@javierm javierm commented Oct 7, 2019

References

Objectives

  • Fix missing and unused Spanish translations
  • Remove an obsolete method
  • Fix typos in translations

This code isn't used since commit eef8ad1.
We probably meant `<br>`, `<br />` or `<br/>`, but wrote `</br>`
instead.
They were accidentally added in commit 9d1ca3b, missing in that same
commit, or left by accident in commit 78c6f6f.
@javierm javierm added the Bug label Oct 7, 2019
@javierm javierm self-assigned this Oct 7, 2019
@javierm javierm added this to Reviewing in Roadmap via automation Oct 7, 2019
@javierm javierm changed the title Fix typos in legacy code Remove and fix legacy code Oct 8, 2019
@javierm javierm changed the title Remove and fix legacy code Fix typos in legacy code Oct 8, 2019
@javierm javierm merged commit 4e37ef0 into master Oct 8, 2019
Roadmap automation moved this from Reviewing to Release 1.1.0 Oct 8, 2019
@javierm javierm deleted the obsolete_code branch October 8, 2019 10:28
smarques pushed a commit to venetochevogliamo/consul that referenced this pull request Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Roadmap
  
Release 1.1.0
Development

Successfully merging this pull request may close these issues.

None yet

1 participant