Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky officing results spec #3754

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Fix flaky officing results spec #3754

merged 1 commit into from
Oct 10, 2019

Conversation

javierm
Copy link
Member

@javierm javierm commented Oct 9, 2019

References

Objectives

Fix a flay spec in spec/features/officing/results_spec.rb:114: "Officing Results Edit result".

Notes

The spec failed failed with the following message if the name of the poll created for that test contained the string "7777":

  1) Officing Results Edit result
     Failure/Error: expect(page).not_to have_content("7777")

       expected not to find text "7777" in "Total recounts and results Language: Deutsch English Español Français Nederlands Português brasileiro 中文 Go back to CONSUL Menu CONSUL Polling Menu Notifications You don't have new notifications My content My account Sign out Admin menu Total recounts and results Go back Poll 0a3f377fb8cc543f6390c77771270676 - Results Booth 35 - October 06, 2019 Totally blank ballots Invalid ballots Valid ballots 6 7 8 Question title 64 Answer Votes Yes 5555 No 200 Question title 65 Answer Votes Today 0 Tomorrow 0"

     # ./spec/features/officing/results_spec.rb:114:in `block (2 levels) in <top (required)>'

@javierm
Fix flaky officing results spec
ef2b231 
The page could have "7777" as a content for the poll's name, since that
name is generated using a random hexadecimal number.

Restricting the search to the area of the page where the "7777" used to
be solves the problem.
@javierm javierm added the Specs label Oct 9, 2019
@javierm javierm self-assigned this Oct 9, 2019
@javierm javierm added this to Reviewing in Roadmap via automation Oct 9, 2019
@javierm javierm merged commit dd6e603 into master Oct 10, 2019
Roadmap automation moved this from Reviewing to Release 1.1.0 Oct 10, 2019
@javierm javierm deleted the flaky_results_spec branch October 10, 2019 18:56
smarques pushed a commit to venetochevogliamo/consul that referenced this pull request Apr 29, 2020
@javierm
Merge pull request consuldemocracy#3754 from consul/flaky_results_spec
75fb1db 
Fix flaky officing results spec
@javierm javierm added Flaky spec and removed Specs labels Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@javierm javierm

Labels
Flaky spec
Projects
No open projects
Roadmap
  
Release 1.1.0
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@javierm