Don't let valuators update investments #3776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some confusing definitions regarding the valuation of budget investments. In the controller, `CommentableActions` was included, which includes the update action. In the abilities, a valuator was given permission to update an investment. However, the action to update an investment didn't work because there is no route defined to do so. The ability was defined so valuators could access the "edit" action, which will not call the "update" action but the "valuate" action. Since internally "edit" and "update" use the same permission, it worked. But then we added permission for regular users to update budget investments, and these permissions were allowing valuators to update another user's investment. After this change, everything seems to work properly since we check authorization in the controller itself instead of using abilities.
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…estment Don't let valuators update investments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Background
There were some confusing definitions regarding the valuation of budget investments. In the controller,
CommentableActionswas included, which includes the update action, and in the abilities, a valuator was given permission to update an investment.However, the action to update an investment didn't work because there is no route defined to do so. The ability was defined so valuators could access the "edit" action.
But then we added permission for regular users to update budget investments, and these permissions were allowing valuators to update another user's investment.
Objectives
Don't let valuators update other user's investments in the public area.
Notes
After this change, everything seems to work properly because the valuation budget investments controller has its own authorization rules, not depending on abilities. We should probably change that, but it's out of the scope of this pull request.