Avoid jumping CKEditor #3824
Merged
Avoid jumping CKEditor #3824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a hack: we're making the textarea have the same size as CKEditor so when it's replaced the page won't jump. A very similar hack was removed in commit e844b0b. Back then I thought this was a small issue we could live with, but the user experience turns out to be a bit annoying, and it makes tests fail sometimes because Capybara is trying to click something when the page jumps, and so it misses the click.
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Avoid jumping CKEditor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Notes
This is a hack: we're making the textarea have the same size as CKEditor so when it's replaced the page won't jump.
A very similar hack was removed in commit e844b0b. Back then I thought this was a small issue we could live with, but the user experience turns out to be a bit annoying, and it makes tests fail sometimes because Capybara is trying to click something when the page jumps, and so it
misses the click.