Update deprecated jQuery syntax #3826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods had already been superseeded by other methods since jQuery 1.7 or 1.8, and jQuery 3.0 will deprecate them.
We moved to chromedriver a long time ago.
Now we do it the same way we attach images in `nested_imageable`. Now we don't need to execute some JavaScript in the test, which by the way was causing an error when upgrading to jQuery 3.
houndci-bot
reviewed
Nov 7, 2019
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…lity Update deprecated jQuery syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
Notes
We aren't upgraded to jQuery 3 yet because the annotator library and the cocoon gem use jQuery 1.x, and we have to test their compatibility with jQuery 3 carefully. Upgrading to jQuery 3 also causes our test for foundation's sticky on mobile phones to fail.