Replace old Spanish text with org name #3838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
reviewed
Nov 9, 2019
PierreMesure
force-pushed
the
replace-spanish-text-with-app-name
branch
from
4c757b7
to
232e6c7
Compare
javierm
approved these changes
Nov 9, 2019
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…nish-text-with-app-name Replace old Spanish text with org name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
It's a tiny PR, it just removes an old Spanish text that would show as title of the page displayed after creating an account: Gobierno abierto.
Right now, I'm using the org name as title, that's open for improvements. It could also say something like "Account created" or "Check your e-mails".
Visual Changes
Before
After