Remove browser gem direct dependency #3860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
remove_browser
branch
from
37bc9ef
to
4b8d48c
Compare
While the browser gem is great, we don't need it in this case for such a simple usage. There are a few really small differences between this code and the old one: matching `/MSIE/` will return true for Opera 12 and false for certain versions of IE11. Since we're only rendering a comment for IE8 and below, we don't care about IE11, and Opera 12 is six years old and its users won't be affected by the comment. Note we're still using the browser gem because ahoy_matey depends on it, but now it's an indirect dependency.
javierm
force-pushed
the
remove_browser
branch
from
4b8d48c
to
442baf8
Compare
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Remove browser gem direct dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
Notes
We're still using the browser gem because ahoy_matey depends on it, but now it's an indirect dependency.