Make it easier to release a new version of CONSUL #3866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
requested changes
Nov 22, 2019
Gemfile
Outdated
| @@ -93,6 +93,7 @@ group :development do | |||
| gem "capistrano3-delayed-job", "~> 1.7.3" | |||
| gem "capistrano3-puma", "~> 4.0.0" | |||
| gem "erb_lint", require: false | |||
| gem "github_changelog_generator" | |||
There was a problem hiding this comment.
For consistency, how about adding ", ~> 1.15.0"?
Rakefile
Outdated
| config.future_release = "1.1.0" | ||
| config.base = "#{Rails.root}/CHANGELOG.md" | ||
| config.token = Rails.application.secrets.github_changelog_token | ||
| config.max_issues = 1 |
There was a problem hiding this comment.
In the past, we had max_issues = 1 in the Rakefile and max_issues = 0 in the .github_changelog_generator file. I don't know which way has precedence 🤔. Is it this one?
With this change we no longer need the branch `changelog` and it will be easier to release new versions of CONSUL.
We only include pull requests, so checking issues isn't useful and takes time.
We were removing the authors manually after they were generated.
javierm
force-pushed
the
releasing_new_version
branch
from
80dd85e
to
96be43a
Compare
javierm
approved these changes
Nov 23, 2019
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…sion Make it easier to release a new version of CONSUL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
With this change we no longer need the branch
changelogand it will be easier to release new versions of CONSUL.Note
The wiki page about releasing a new version needs to be adjusted