Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smtp settings for staging environment on secrets #3870

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

taitus
Copy link
Member

@taitus taitus commented Nov 26, 2019

References

Related PR: Installer: Add Staging configuration #138

Objectives

Add smtp settings for staging environment

Visual Changes

None

Add smtp settings for staging environment
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @taitus 😄. I guess I suffered from the broken window syndrome when I added the SMTP settings to the secrets.yml file; since we had forgotten to add some settings to the staging environment in the past, I didn't bother to add SMTP settings either 😅.

@javierm javierm merged commit 11adacf into consuldemocracy:master Nov 26, 2019
@javierm javierm added this to Reviewing in Roadmap via automation Feb 27, 2020
@javierm javierm moved this from Reviewing to Release 1.1.0 in Roadmap Feb 27, 2020
@javierm javierm self-assigned this Feb 27, 2020
smarques pushed a commit to venetochevogliamo/consul that referenced this pull request Apr 29, 2020
…s-example

Add smtp settings for staging environment on secrets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Roadmap
  
Release 1.1.0
Development

Successfully merging this pull request may close these issues.

None yet

2 participants