Sanitize values before sending them to remote translation client #3874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 3, 2019
Sanitize resource fields values from ddbb before send to remote translate client.
taitus
force-pushed
the
sanitize-descriptions-on-remote-translations
branch
from
b9251b8
to
d1c9df5
Compare
taitus
changed the title
javierm
approved these changes
Dec 10, 2019
javierm
changed the title
javierm
changed the title
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…riptions-on-remote-translations Sanitize values before sending them to remote translation client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Sanitize resource fields values from ddbb before send to remote translate client.
Visual Changes
None
Notes
Before we saved the sanitized values in database
In #3749 was removed sanitize before saving in database and is only managed in the views.
The remote translation feature has been affected by this change, as we send the database value directly to the remote translation client. The solution is to sanitize the values of the fields before sending them to the remote translation client.