Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style for validation errors in HTML areas #3900

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

javierm
Copy link
Member

@javierm javierm commented Jan 17, 2020

References

Objectives

Fix a bug which caused extra blank space to appear after validation erros related to CKEditor fields.

Visual Changes

Before these changes:

Ther's blank space after the validation error

After these changes:

There's no blank space after the validation error

Rails automatically adds the field class to the validation error
message, and so it had an unusual height.
@javierm javierm added the Bug label Jan 17, 2020
@javierm javierm self-assigned this Jan 17, 2020
@javierm javierm added this to Reviewing in Roadmap via automation Jan 17, 2020
@javierm javierm merged commit bae9992 into master Jan 17, 2020
Roadmap automation moved this from Reviewing to Release 1.1.0 Jan 17, 2020
@javierm javierm deleted the fix_ckeditor_validation_error branch January 17, 2020 15:41
smarques pushed a commit to venetochevogliamo/consul that referenced this pull request Apr 29, 2020
…dation_error

Fix style for validation errors in HTML areas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Roadmap
  
Release 1.1.0
Development

Successfully merging this pull request may close these issues.

None yet

1 participant