Expire investment cache when its image changes #3913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've added the option to remove an image from an investment. However, removing the image did not expire the cache, so the rendered HTML still included an `<image>` tag (which wouldn't show an image, since it had been deleded) and a link to remove an image.
microweb10
approved these changes
Feb 5, 2020
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Expire investment cache when its image changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We've added the option to remove an image from an investment. However,
removing the image did not expire the cache, so the rendered HTML still
included an
<image>tag (which wouldn't show an image, since it hadbeen deleded) and a link to remove an image.
Objectives
Fix a bug resulting in an empty image being shown after removing it.
Visual Changes
Before these changes: