Fix hidden active elements in admin menu #3926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the admin menu, some links take you to a section, and some links open a submenu with more links. When we disable the "multi-open" property of the menu and the active element is a link which takes you to a section, Foundation will hide it whenever we click a link which opens a submenu. The easiest solution is to enable "multi-open" property.
decabeza
approved these changes
Feb 20, 2020
microweb10
approved these changes
Feb 21, 2020
|
Well done! Pretty sure I opened an issue about it two years ago but can’t find it. |
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Fix hidden active elements in admin menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In the admin menu, some links take you to a section, and some links open a submenu with more links.
When we disable the "multi-open" property of the menu and the active element is a link which takes you to a section, Foundation will hide it whenever we click a link which opens a submenu.
Objectives
Make sure active menu items aren't hidden when navigating through the menus.
Visual Changes
Before these changes:
After these changes: