Specify which bundler version to install #3931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're now using the same version we used to generate our Gemfile.lock. Using the latest bundler we got a deprecation warning, which might turn into an error in the future: [DEPRECATED] The `--deployment` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. We could also upgrade to bundler 2.x, but since we're using Ruby 2.4 and Ruby 2.6 comes with bundler 1.17, we've decided to keep this version.
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Specify which bundler version to install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Using the latest bundler we got a deprecation warning, which might turn into an error in the future:
Objectives
Use the same version of Bundler we used to generate our Gemfile.lock.
Notes
We could also upgrade to bundler 2.x, but since we're using Ruby 2.4, and Ruby 2.6 comes with bundler 1.17, we've decided to keep this version.