Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade sassc from 2.4.0 to 2.2.1 #4097

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Downgrade sassc from 2.4.0 to 2.2.1 #4097

merged 1 commit into from
Aug 25, 2020

Conversation

javierm
Copy link
Member

@javierm javierm commented Aug 22, 2020

References

Background

Using sassc 2.4.0, we were getting several warnings when compiling Foundation's assets:

DEPRECATION WARNING (...) !global assignments won't be able to declare new variables in future versions.

Objectives

  • Make sure we don't get any warnings when compiling our assets

Notes

Using sassc 2.3.0 my machine froze when trying to compile the assets in our current master branch, and that's why we're downgrading to version 2.2.1 instead.

@javierm javierm added the dependencies Pull requests that updates a dependency label Aug 22, 2020
@javierm javierm added this to Reviewing in Consul Democracy via automation Aug 22, 2020
@javierm javierm self-assigned this Aug 22, 2020
@javierm javierm added the 1.2 label Aug 22, 2020
@taitus taitus self-assigned this Aug 24, 2020
Using sassc 2.4.0, we were getting several warnings when compiling
Foundation's assets:

DEPRECATION WARNING (...) !global assignments won't be able to declare
new variables in future versions.

According to issue 12080 in Foundation's repository, it won't be fixed
before Foundation 7.

Using sassc 2.3.0 my machine froze when trying to compile the assets in
our current master branch, so I'm downgrading to version 2.2.1.
Consul Democracy automation moved this from Reviewing to Testing Aug 25, 2020
@javierm javierm merged commit 59b7b52 into master Aug 25, 2020
Consul Democracy automation moved this from Testing to Release 1.2.0 Aug 25, 2020
@javierm javierm deleted the downgrade_sassc branch August 25, 2020 10:53
@javierm javierm removed the 1.2 label Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants