Simplify code in the admin menu #4274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way adding new methods will be easier.
We no longer need to use the `menu_` prefix, since now these methods aren't helper methods anymore, and so their names won't collide with other helpers.
The HTML `class` attribute was declared twice and so the second one was being ignored. In the case of messages, it was "working" properly because the `class=is-active` part is not used on `<li>` tags when they've got a `<ul>` inside them.
Now that there's no naming confict with the helper method used in the ProposalsDashboardHelper, we can easily simplify the view, moving the logic to the Ruby class.
It isn't used anywhere, and we could achieve the same result using the CSS child selector `> li`.
From a semantic point of view, there's no reason to add a strong emphasis to the menu items. Besides, using CSS simplifies the code and is less error-prone. For instance, the "stats" section didn't have a <strong> tag, and so it was the only one which wasn't bold.
This way we simplify the HTML and generating similar menus will be easier. We also improve the experience for screen reader users, who might have been hearing the icons as text because we weren't using the `aria-hidden` attribute. We're still keeping the "icon-" classes for compatibility with CONSUL installations which might have changed this code.
taitus
approved these changes
Dec 2, 2020
This was referenced Dec 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
Visual Changes
Before these changes
After these changes