Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up doc folder #5087

Merged
merged 5 commits into from
Mar 3, 2023
Merged

Clean up doc folder #5087

merged 5 commits into from
Mar 3, 2023

Conversation

javierm
Copy link
Member

@javierm javierm commented Mar 1, 2023

References

Objectives

  • Remove files which have already been moved to the documentation repository
  • Fix broken API examples

It's already present in the consul/docs repository.

We're keeping the examples folder for now because it isn't in the
consul/docs repository yet.
We added them in commit 2e4601b, but it looks that they've never been
used.
This documentation is obsolete and there's documentation in the official
consulproject website containing user guides like this one.
We were getting many errors when trying to run them, from uninitialized
constant `HTTP` to undefined method `headers`.

We might move these examples to the documentation repository in the
future, but we need to look for possible side-effects first.
Consul Democracy automation moved this from Reviewing to Testing Mar 3, 2023
@javierm javierm merged commit 462792d into master Mar 3, 2023
Consul Democracy automation moved this from Testing to Release 2.0.0 Mar 3, 2023
@javierm javierm deleted the doc_folder branch March 3, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants