Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard feature #2981

Open
decabeza opened this issue Oct 18, 2018 · 0 comments
Open

Dashboard feature #2981

decabeza opened this issue Oct 18, 2018 · 0 comments

Comments

@decabeza
Copy link
Collaborator

decabeza commented Oct 18, 2018

Background

We have been working recently on a new dashboard feature for proposals on the following PRs:

What we need

Fix some details to polish this feature: 馃槍

  • In /proposals/N/dashboard/actions/N/new_request mark sidebar menu as active. It's necessary fix something related with is_request_active helper on proposals_dashboard_helper.rb:42.

  • When admin create a new action on /admin/dashboard/actions/new and adds some link, the Cancel link doesn't work and generates an error when send the form.

Add some improvements: 馃

  • Replace best in place gem to a regular form because is used only one time on dashboard/polls/_poll.html.erb:26.

  • Maybe a little refactor on models/abilities/common.rb to avoid use proposal.author.id == user.id four times.

  • Maybe config.action_mailer.preview_path = "#{Rails.root}/spec/mailers/previews" on config/environments/development.rb it's not necessary an we can keep using :letter_opener.

  • Review how to use custom fonts with wicked_pdf gem to avoid create a new stylesheets/pdf_fonts.scss.erb file and duplicate all fonts files on vendor/assets/fonts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants