Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clearer when a proposal was created "on behalf of" someone else #3696

Open
PierreMesure opened this issue Sep 12, 2019 · 3 comments
Open

Comments

@PierreMesure
Copy link
Collaborator

User Story

As a participatory budget organiser, we allow people to leave proposals physically in a box in the public library. We also organise several physical events during which people can contribute with ideas but we don't necessarily make them create an account and add their projects on the platform.

As a participatory budget organiser, I want to be able to create proposals and budget investments on behalf of someone and that the identity of that person be clearly visible.

Currently, it is possible to add a proposal on behalf of a group or an organisation and this works perfectly fine for our use case as well:

What we would like to improve is the visibility of the proposal author's name in the list of proposals and on the proposal's page.

Why is this Needed?

To make sure that there is no misunderstanding and so it doesn't look like a majority of the proposals have been left by the admin.

Description

Type: Feature

Current Behavior

Creation form

Capture d’écran 2019-09-12 à 09 01 58

Proposal page

You can then see that the proposal was written on behalf of someone at the bottom:

Capture d’écran 2019-09-12 à 09 00 48

Expected Behavior

Capture d’écran 2019-09-12 à 09 06 55

Capture d’écran 2019-09-12 à 09 12 04

Definition of Done

  • text present in the list view
  • text present in the proposal view
  • (optional) change the avatar letter so it matches the proposal author and not the one who wrote it on behalf
  • (optional) remove the text at the bottom of the proposal which is quite confusing currently
@matisnape
Copy link
Collaborator

I think I'm gonna take it :)

@PierreMesure
Copy link
Collaborator Author

Great to hear Anna! Don't hesitate to ask for help!

@matisnape
Copy link
Collaborator

matisnape commented Oct 12, 2019

@PierreMesure
BTW, I found 2 bugs on master when I create a new investment as admin

  1. visual in route /management/budgets/:id/investments/new https://monosnap.com/file/fHqPiDojfRwjFUaPjoQQ9K1q105a0f
  2. some problem with partial in Management http://localhost:3000/management/budgets/:id/investments/:id https://monosnap.com/file/AKU4LfRFVhEn1bmNAcGTrbS4aYOdLh

Are you aware of those? If you can reproduce, can I create a new issue and try to fix it? I see that budget_investments_spec.rb and proposals_spec.rb are passing, but I'm not sure why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants