Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky specs: Legislation Draft Versions annotations #4713

Open
javierm opened this issue Oct 17, 2021 · 0 comments
Open

Flaky specs: Legislation Draft Versions annotations #4713

javierm opened this issue Oct 17, 2021 · 0 comments

Comments

@javierm
Copy link
Member

javierm commented Oct 17, 2021

References

Background

We're selecting a word using a double click. However, the test fails sometimes when styles such as font family, font size or the element's width change, since the double click takes place in the middle of the element and it's possible that the middle of the element contains a space between two words, meaning no word would be selected.

Current behavior

The tests select a random word in the middle of the element; the random word might actually be a space instead of a word

Expected behavior

The tests are consistent and we control which text is selected

Notes

  • On some machines, without these changes, the failure in the "Create" test can be reproduced by changing the $base-font-size variable to 2rem or changing the default font family to Roboto
  • This failure shows a usability/accessibility issue: adding annotations is hard, particularly when using a touchscreen or a keyboard (see issue Can't add annotations with the keyboard #4831)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant