Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for images inside of the poll options #5171

Open
markusgeert opened this issue Aug 10, 2023 · 2 comments
Open

Support for images inside of the poll options #5171

markusgeert opened this issue Aug 10, 2023 · 2 comments

Comments

@markusgeert
Copy link
Contributor

User Story

As a user, I want to be able to add images directly to poll buttons, so I understand what I'm voting on, without having to look for the corresponding images.

Why is this Needed?

Currently images added to polls appear underneath the answers of the poll. This is confusing to users of the poll, since it requires them to locate the images and connect them to the answers of the poll correctly, giving them less confidence in having entered the correct answer. It gets even more confusing when the images fall off the screen, and the user has to scroll between the poll itself and the associated images.

This would be especially helpful when the user has to pick which of the options they find the best looking, for example when selecting public bins.

Description

Type: Feature

Current Behavior

The images appear below the questions.

Expected Behavior

It would be great if the images appear inside the answer itself, like so:

Screenshot 2023-08-10 at 12 04 06

Let me know if this would be a desired feature. If so, I would be willing to create a PR.

@javierm
Copy link
Member

javierm commented Aug 10, 2023

@markusgeert Thanks for the issue!

We're currently thinking about making some big interface changes in the polls section for version 2.1, and this is definitely something to think about.

Let me know if this would be a desired feature. If so, I would be willing to create a PR.

At this stage, and due to the possible changes mentioned above, maybe it'd be useful if you could implement a kind of "mockup feature". I mean, a pull request with changes that cause a poll to render the way you have in mind, but that might break everything else or have a huge amount of bugs. Just something to play around so we can check what it'd look like on a real browser (both small and large screens).

What do you think? What I'm trying to avoid is asking you to work for a long time on something that we aren't sure we are going to include, but if you don't like the idea, say so 😉, and maybe we can think of something else.

@markusgeert
Copy link
Contributor Author

markusgeert commented Aug 10, 2023

@javierm thank you for the reply.

Great to hear something like this is already on the roadmap! Internally we have a couple more issues and features that are currently also on a high priority for us, so I might get around to doing those first. I'll let you know when I start work on a PR 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants