Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legislation Debate can comment on closed process #5247

Open
coslajohn opened this issue Sep 12, 2023 · 1 comment
Open

Legislation Debate can comment on closed process #5247

coslajohn opened this issue Sep 12, 2023 · 1 comment
Labels

Comments

@coslajohn
Copy link
Contributor

There is some strange inconsistent behaviour regarding Open Answers to Legislation Debates

Sometimes, when the debate process is closed it is still possible to Comment/Leave an open answer when looking at the Most Voted tab

image

If you click on the Newest First or Oldest First tab it shows the correct behaviour as below

image

@javierm javierm added the Bug label Sep 12, 2023
@yasirazgar
Copy link

@javierm @coslajohn

This seems to be expected behaviour for admins and moderators - https://github.com/consuldemocracy/consuldemocracy/blob/master/app/controllers/comments_controller.rb#L110

For other roles it seems to work as expected.
Screenshot 2023-10-24 at 12 23 53

Currently once the legislative debate is closed and if in the other tab which has the respective debate page already in open, without refreshing the debate page an user is allowed to answer the debate and if the user is admin/moderator due the above if condition the backed validation allows the comment.
Do you guys want me modify the UI to explicitly allow the admins and moderator to post answers i.e even after refreshing the page. Or disable this option for admins and moderators as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants