Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moderation comments: Error when rendering a link to hidden commentable #5253

Open
Senen opened this issue Sep 21, 2023 · 0 comments
Open

Moderation comments: Error when rendering a link to hidden commentable #5253

Senen opened this issue Sep 21, 2023 · 0 comments
Labels

Comments

@Senen
Copy link
Member

Senen commented Sep 21, 2023

User Story

When a comment from a hidden Legislation::Proposal is shown in the moderation comments section the generated link is wrong, it points to an unexisting proposal instead of a legislation proposal.

Why is this Needed?

Avoid user confusion and generating unexisting URLs.

Description

We should avoid generating the commentable link when it's hidden.

Current Behavior

The application shows a link with an unexisting URL when the commentable is hidden.

Expected Behavior

The application does NOT show the link when the commentable is hidden, in place of the link, it should show the same as the administration comments section.

Steps to reproduce

  1. Hide a legislation proposal with comments
  2. Go to the moderation comments section and verify the comments from the legislation proposal have badly generated links.

Definition of Done

The application does NOT show the link when the commentable is hidden, in place of the link, it should show the same as the administration comments section.

@Senen Senen added the Bug label Sep 21, 2023
@Senen Senen changed the title Moderation comments: Error when rendering links to hidden commentable Moderation comments: Error when rendering a link to hidden commentable Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant