Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix examples in docs #89

Merged
merged 14 commits into from
Oct 17, 2022
Merged

Fix examples in docs #89

merged 14 commits into from
Oct 17, 2022

Conversation

illusionTBA
Copy link
Contributor

What kind of change does this PR introduce?

  • Fixes code examples used in the docs

If relevant, did you update the documentation?

  • Yes

Summary

  • In short, all the code examples in the docs were missing a closing parenthesis to end the .then statement.

@riimuru
Copy link
Contributor

riimuru commented Oct 17, 2022

@illusionTBA can you do the same thing for other providers

@illusionTBA
Copy link
Contributor Author

i thought i already did all the providers, did i miss one ?

@riimuru
Copy link
Contributor

riimuru commented Oct 17, 2022

@illusionTBA nvm i'm just tired 😅.

@riimuru riimuru merged commit cad58af into consumet:master Oct 17, 2022
@riimuru riimuru changed the title Fixes examples in docs Fix examples in docs Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riimuru riimuru Awaiting requested review from riimuru riimuru is a code owner

@prince-ao prince-ao Awaiting requested review from prince-ao prince-ao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@illusionTBA @riimuru