Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for zoro dubs #93

Merged
merged 3 commits into from
Oct 22, 2022
Merged

Added support for zoro dubs #93

merged 3 commits into from
Oct 22, 2022

Conversation

ErrorErrorError
Copy link
Collaborator

What kind of change does this PR introduce?

This pr brings support for fetching zoro dub.

Did you add tests for your changes?

No

Summary
You can retrieve the server for dub and sub from zoro. I also added subOrDub as an option of AnimeInfo.

Other information

my brain is friend ngl

@ErrorErrorError
Copy link
Collaborator Author

ErrorErrorError commented Oct 22, 2022

Currently I will modify how users can get the sub and dub episodes for the api.

It will be by appending either sub or dub at the end of the episode id, and then extracting it in the provider.

@riimuru
Copy link
Contributor

riimuru commented Oct 22, 2022

Currently I will modify how users can get the sub and dub episodes for the api.

It will be by appending either sub or dub at the end of the episode id, and then extracting it in the provider.

Sounds like a better approach👍.

@ErrorErrorError ErrorErrorError marked this pull request as draft October 22, 2022 15:49
@ErrorErrorError ErrorErrorError marked this pull request as ready for review October 22, 2022 20:25
Copy link
Contributor

@riimuru riimuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riimuru riimuru merged commit bd2aec8 into consumet:master Oct 22, 2022
@riimuru riimuru linked an issue Nov 13, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Dubbed on zoro
2 participants