Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contextInfo cannot be set #32

Closed
dhinus opened this issue May 31, 2017 · 0 comments
Closed

contextInfo cannot be set #32

dhinus opened this issue May 31, 2017 · 0 comments
Assignees
@dhinus

Comments

@dhinus
Copy link
Contributor

dhinus commented May 31, 2017 •
edited by prismabot

Trello card

The 'config' call should accept an optional contextInfo attribute

ch('config', {
  context: 'CTX', //already implemented
  contextInfo: { ... } //at the moment this is ignored
});

The contextInfo object should then be added to all "event" payloads, in the same way it is already done for the context string.
@dhinus dhinus added the defect label May 31, 2017
@dhinus dhinus self-assigned this May 31, 2017
@nemobot nemobot added the WIP label May 31, 2017
@dhinus dhinus mentioned this issue May 31, 2017
Merged
@nemobot nemobot added in review and removed WIP labels May 31, 2017
@dhinus dhinus closed this as completed in #33 Jun 1, 2017
dhinus added a commit that referenced this issue Jun 1, 2017
@dhinus
Merge pull request #33 from contactlab/32-contextinfo_cannot_be_set
8513472 
#32: contextInfo cannot be set (closes #32)
@nemobot nemobot removed the in review label Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhinus dhinus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhinus @nemobot