Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset cookie if token changes #40

Closed
dhinus opened this issue May 21, 2018 · 0 comments
Closed

Reset cookie if token changes #40

dhinus opened this issue May 21, 2018 · 0 comments
Assignees
@dhinus

Comments

@dhinus
Copy link
Contributor

dhinus commented May 21, 2018

Trello card

description

If the Contacthub API token changes, we should delete any information we have stored in the _ch cookie. Not doing so has caused some issues to a customer (I don't remember the details anymore).

specs

Store the token in the cookie, and check if it changes. When it does, reset the cookie.

misc
@dhinus dhinus self-assigned this May 21, 2018
@nemobot nemobot added the WIP label May 23, 2018
@dhinus dhinus mentioned this issue May 24, 2018
Merged
@nemobot nemobot added in review and removed WIP labels May 24, 2018
dhinus added a commit that referenced this issue May 25, 2018
@dhinus
Merge pull request #42 from contactlab/40-reset_cookie_if_token
6a53536 
#40: Reset cookie if token changes (closes #40)
@nemobot nemobot removed the in review label May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhinus dhinus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhinus @nemobot