This repository has been archived by the owner on Apr 26, 2019. It is now read-only.
The replace property is not mandatory anymore (#57)
#86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LasaleFamine, thanks for your PR! By analyzing the history of the files in this pull request, we identified @StefanoMagrassi to be a potential reviewer. |
1 similar comment
| return new Promise((resolve, reject) => { | ||
| try { | ||
| const changedCSS = replaceInFile.sync(optionCSS); | ||
| const changedJS = replaceInFile.sync(optionJS); | ||
| const changedCSS = replaceInFile.sync(optionCSS.files ? optionCSS : defaultOptions); |
There was a problem hiding this comment.
@LasaleFamine maybe you can use Ramda's merge method
There was a problem hiding this comment.
As discuss, we can introduce new logic (and libs) during the refactor.
| const changedCSS = replaceInFile.sync(optionCSS); | ||
| const changedJS = replaceInFile.sync(optionJS); | ||
| const changedCSS = replaceInFile.sync(optionCSS.files ? optionCSS : defaultOptions); | ||
| const changedJS = replaceInFile.sync(optionJS.files ? optionJS : defaultOptions); |
There was a problem hiding this comment.
@LasaleFamine same as previous comment
test/index.test.js
Outdated
| @@ -115,6 +115,18 @@ test('replace() products correct output', async t => { | |||
| t.is(fileReplace, `<!DOCTYPE html><html><head>\n <meta charset=\"utf-8\">\n <title></title>\n\n \n <link rel=\"stylesheet\" href=\"/assets/style.css\">\n \n\n \n <script src=\"/assets/javascript.js\"></script>\n \n\n </head>\n <body>\n\n \n\n</body></html>`); | |||
| }); | |||
|
|
|||
| test('when running replace() the "replace" property of configuration is not mandatory', async t => { | |||
| const {tmpDir, webpackConfig} = t.context; | |||
| const config = hconf(tmpDir, ['FOLDERS', 'VULCANIZE_NO_JS', 'MANIFEST']); | |||
There was a problem hiding this comment.
@LasaleFamine maybe 'MANIFEST' configuration is useless here
There was a problem hiding this comment.
Now should be correct.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.