Top banner #60
Merged
Top banner #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimanshi-plivo
commented
Aug 4, 2023
mimanshi-plivo
commented
- Added top banner to style guides
src/components/TopBanner/index.js
Outdated
| > | ||
| {loading && ( | ||
| <Block> | ||
| <Icon.Loading size={16} color="white" /> |
There was a problem hiding this comment.
Icon.Loading has strokeWidth and trackColor props. You can use it if you want. Not sure if color="white" is what we want.
| gap: 16px; | ||
| // margin-left: 4px; | ||
|
|
||
| .sg.cnto-btn.contacto-button--small { |
There was a problem hiding this comment.
Can we move this style to Button.scss file?
There was a problem hiding this comment.
May be add a new button type
<Button type="link" variant="underline" color="white" />| &--underline { | ||
| text-decoration: underline; | ||
| height: 24px; | ||
| padding: 0; |
There was a problem hiding this comment.
Is there any hover style required?
samuellawerentz
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.