Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds VCR Specs #21

Merged
merged 3 commits into from
Jan 20, 2016
Merged

Adds VCR Specs #21

merged 3 commits into from
Jan 20, 2016

Conversation

jwg2s
Copy link
Contributor

@jwg2s jwg2s commented Jan 20, 2016

Developer Checklist

  • I considered alternative approaches and chose the simplest one.
  • I wrote unit/acceptance specs for these changes that test all possible conditions (success, failure, bad input, etc).
  • I wrote unit/acceptance specs for code/functionality these changes may have affected.
  • I can't think of any other code/functionality this may have affected that I didn't test or account for.
  • I've ensured any necessary data migrations have been run.
  • I've ensured other blocking code has been deployed (e.g. if part of a larger feature).
  • We are able to track any changes to application performance or utilization introduced by this PR.

Deploying is blocked by:

  • Nothing :shipit:

shaunr0b
shaunr0b reviewed Jan 20, 2016
View reviewed changes
spec/integration/subscription_spec.rb
response = client.post('/rest/v1/subscriptions', subscription)
expect(response.body['success']).to be_truthy
expect(response.body['subscriptionId'].present?).to be_truthy
puts response.body['subscriptionId']
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was puts left here intentionally?

@shaunr0b
Copy link

Looks great, just one small comment, otherwise good to go. Nice work!

@jwg2s
Copy link
Contributor Author

jwg2s commented Jan 20, 2016

@env fixed the puts issue, should be g2g now

jwg2s added a commit that referenced this pull request Jan 20, 2016
@jwg2s
Merge pull request #21 from contactually/feature/vcr
410aad7 
Adds VCR Specs
@jwg2s jwg2s merged commit 410aad7 into develop Jan 20, 2016
@jwg2s jwg2s deleted the feature/vcr branch January 20, 2016 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jwg2s @shaunr0b