Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider make it build with stable rustc #28

Closed
zonyitoo opened this issue Oct 1, 2015 · 8 comments
Closed

Consider make it build with stable rustc #28

zonyitoo opened this issue Oct 1, 2015 · 8 comments

Comments

@zonyitoo
Copy link

zonyitoo commented Oct 1, 2015

Currently it rely on these 3 unstable features:

#![feature(hashmap_hasher)]
#![feature(box_raw)]
#![feature(iter_order)]

Could it be replaced by some stable features to make it build with stable rustc.

@apasel422
Copy link
Contributor

box_raw is stable now, and iter_order can easily be cfg-ed off with a nightly feature (or worked around), but eliminating hashmap_hasher would require removing the S parameter from LinkedHashMap. I'm not opposed to this, as it doesn't seem like that feature is going to be stabilized any time soon, but it's a significant change.

@zonyitoo
Copy link
Author

zonyitoo commented Oct 1, 2015

Maybe you guys could ask the official team to stabilize the hashmap_hasher?

@apasel422
Copy link
Contributor

The exact API hasn't been chosen yet. See rust-lang/rust#27713.

@fenhl
Copy link
Contributor

fenhl commented Nov 11, 2015

The above issue is now in its final comment period and will likely be stabilized in Rust 1.6.

@dylanede
Copy link

Just a note that this still doesn't build on stable.

@apasel422
Copy link
Contributor

This isn't going to build on stable until 1.7 is released, but with that in
mind, I would accept a PR that enables testing on beta in Travis.

On Wed, Feb 10, 2016 at 1:30 PM, Dylan Ede notifications@github.com wrote:

Just a note that this still doesn't build on stable.


Reply to this email directly or view it on GitHub
#28 (comment)
.

@reem
Copy link
Member

reem commented Feb 13, 2016

In the meantime I am maintaining a very small and temporary fork that works on stable here, available on crates.io as terminal-linked-hash-map; do note that I plan to stop maintaining this fork as soon as this crate can build on stable.

@apasel422
Copy link
Contributor

With the release of Rust 1.7, this appears to build on stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants