Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have serde feature be called serde #38

Closed
jonhoo opened this issue Jun 29, 2017 · 2 comments
Closed

Have serde feature be called serde #38

jonhoo opened this issue Jun 29, 2017 · 2 comments

Comments

@jonhoo
Copy link
Contributor

jonhoo commented Jun 29, 2017

The serde feature for vec-map is currently counter-intuitively called edres, presumably because of rust-lang/cargo#1286. There is a workaround for this problem in serde itself (https://github.com/serde-rs/serde/blob/v1.0.0/serde/src/lib.rs#L222-L260), whereby you depend on serde with the derive feature, which in turn re-exports derive(Serialize, Deserialize) from serde_derive. This allows the feature of the top-level crate (in this case vec-map) to also be called serde. Or rather, it allows you to not explicitly add a feature called serde, but instead rely on the behavior that optional dependencies are implicitly also features.

@Gankra
Copy link
Contributor

Gankra commented Jul 26, 2017

sgtm? I completely missed all this happening.

@Boscop
Copy link

Boscop commented Apr 21, 2018

Any update on this? :)

It would just be a few lines, like this:
https://github.com/softdevteam/vob/pull/10/files

oherrala added a commit to oherrala/vec-map that referenced this issue May 11, 2018
The old feature "eders" is kept for backwards compability.

Fixes contain-rs#38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants