Add values_mut (fixes #36) and shrink_to_fit (fixes #28). #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gankro @apasel422 you two seem to be the ones able to merge this? |
pczarn
approved these changes
Jun 16, 2017
pczarn
reviewed
Jun 16, 2017
| @@ -191,6 +191,22 @@ impl<V> VecMap<V> { | |||
| } | |||
| } | |||
|
|
|||
| /// Trims the `VecMap` of any excess capacity. | |||
There was a problem hiding this comment.
don't you think "excess capacity" could also describe Nones that may remain at the end of the array?
There was a problem hiding this comment.
yes and I will add a fix for this momentarily!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.