Implement PSR-11?

[mnapoli]

Hi everyone :)

For those not following the latest events, PSR-11 has gone into vote and it's going quite well. If it passes, what should we do (and what can we do)?

Is there any technical reason not to implement PSR-11?

Should we deprecate container-interop?

My opinion for what it's worth:

• if there is nothing preventing that, this package should extend PSR-11 (for an easy migration)
• it could be deprecated, but we shouldn't forget about the dependency lookup feature (which is not included in PSR-11)

[Sam-Burns]

I'm sure there are a lot of other aspects to consider, but it's worth giving some thought to composite containers like Ultra-Lite and Acclimate.

These currently do things like:

public function addDelegateContainer(\Interop\Container\ContainerInterface $delegate)

I would rather not have to switch to:

public function addDelegateContainer($delegate)
{
    if (
        !$delegate instanceof \Interop\Container\ContainerInterface
        && !$delegate instanceof \Psr\Container\ContainerInterface
    ) {
    throw //...

Simple interface inheritance would seem to solve that problem for us.

One way or the other though, adding support for PSR-11 seems likely, even if it means just providing LTS Container-Interop support and phasing it out for new versions.

[Ocramius]

Huge 👍 if this package can just provide PSR-11 compatibility via transitivity: that removes a lot of headaches for a big amount of libraries implementing it, if the API matches 1:1

…

On 8 Feb 2017 6:22 p.m., "Matthieu Napoli" ***@***.***> wrote: Hi everyone :) For those not following the latest events, PSR-11 has gone into vote and it's going quite well. If it passes, what should we do (and what can we do)? Is there any technical reason not to implement PSR-11? Should we deprecate container-interop? My opinion for what it's worth: - if there is nothing preventing that, this package should extend PSR-11 (for an easy migration) - it could be deprecated, but we shouldn't forget about the dependency lookup feature (which is not included in PSR-11) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#90>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakF9m_uWy_52ilPq3vppGiUNdMRV9ks5rafnCgaJpZM4L7G5Q> .

[moufmouf]

Actually, I was thinking about writing a PR for this.

Huge 👍 too.

There is nothing that prevents us from extending PSR-11 interfaces and we should definitely do it. The container-interop definition of NotFoundException is vague enough so that it can fit in the very broad definition adopted by PSR-11.

Regarding deprecating "container-interop", the only thing that is in container-interop and that is not in PSR-11 is the delegate lookup feature, but as stated on the PHP-FIG mailing list, this is a design pattern. So deprecating the package does not mean deprecating the design pattern in my opinion. The design pattern lives by itself :)

So 👍 for deprecating the package too. We might want to think about a way to keep the text about the delegate lookup feature in another repository though, in order not to loose the work done on it.... A Couscous website maybe?

[Potherca]

👍 for

• \Interop\Container\ContainerInterface exends \Psr\Container\ContainerInterface
• deprecating container-interop

In regards to the delegate lookup feature, documentation seems the way to go (like the phpleague, for example). The question would be where does such documentation belong?

(On a side-note, voting currently stands at 17, all in favour 😸)

[shochdoerfer]

First of all, awesome work guys! Never thought that this could ever happen given the feedback I got back in 2011 / 2012 when I proposed the idea to the FIG.

Is it really worth to let container-interop extend PSR-11? I mean I guess most libs should pretty soon move to PSR-11? I mean it does not hurt but I wonder if it is worth it? Especially when container-interop would be deprecated the same time.

[Ocramius]

Having all libs manually move to PSR-11 is quite a bother, while extending the standard makes the migration much more graceful. Consider that otherwise it's major bc breaks for all implementations 😨

…

On 9 Feb 2017 8:47 a.m., "Stephan Hochdörfer" ***@***.***> wrote: First of all, awesome work guys! Never thought that this could ever happen given the feedback I got back in 2011 / 2012 when I proposed the idea to the FIG. Is it really worth to let container-interop extend PSR-11? I mean I guess most libs should pretty soon move to PSR-11? I mean it does not hurt but I wonder if it is worth it? Especially when container-interop would be deprecated the same time. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#90 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakODMoOQM5_eaMWVCMItStJN_56BEks5rasStgaJpZM4L7G5Q> .