Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets in NodeExpandVolume #445

Closed
Sh4d1 opened this issue Aug 20, 2020 · 6 comments · Fixed by #457
Closed

Secrets in NodeExpandVolume #445

Sh4d1 opened this issue Aug 20, 2020 · 6 comments · Fixed by #457

Comments

@Sh4d1
Copy link
Contributor

Sh4d1 commented Aug 20, 2020

Hello!

It would be nice to have secrets available in the NodeExpandVolume.

Usecase : encrypted device with LUKS, which needs the passphrase in order to resize the device on the node.

@humblec
Copy link
Contributor

humblec commented Aug 20, 2020

Indeed , this is a requirement for other use case too. For example, if we need to connect to backend cluster for some validation we need the secret.

One of the use case came up Ceph side is that, at times we need to check the actual size of the image before proceeding on FS resize to avoid false positive returns on fs resize operation. For that we have to connect to the backend cluster which need secret in the request.

@Sh4d1
Copy link
Contributor Author

Sh4d1 commented Aug 20, 2020

Not sure what the policy is, but I'll gladly open a PR adding secrets to this method 😄

@humblec
Copy link
Contributor

humblec commented Aug 20, 2020

Not sure what the policy is, but I'll gladly open a PR adding secrets to this method smile

Let me invite some key members for their thought from Kube storage side.
@saad-ali @jsafrane @msau42 @gnufied @xing-yang can you share your thoughts ?

@humblec
Copy link
Contributor

humblec commented Oct 7, 2020

@gnufied @jsafrane @xing-yang @msau42 @saad-ali this is one of the blocker to support LUKS encryption expansion for CSI drivers. We indeed need secrets/credentials in the NodeExpand request. Can we share your thoughts ?

@Sh4d1 would you like to open a PR for this?

@Sh4d1
Copy link
Contributor Author

Sh4d1 commented Oct 7, 2020

@humblec yep 😄

@humblec
Copy link
Contributor

humblec commented Oct 7, 2020

@humblec yep smile

Thanks @Sh4d1 ! Let me pull others to the PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants