Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrectly named field #392

Merged

Conversation

bswartz
Copy link
Contributor

@bswartz bswartz commented Oct 21, 2019

The fields added to NodeGetVolumeStatsRequest and NodeExpandVolumeRequest
should have been staging_target_path rather than staging_path. This change
corrects that mistake.

Also remove the extraneous "when possible" wording around when to supply
these fields.

The fields added to NodeGetVolumeStatsRequest and NodeExpandVolumeRequest
should have been staging_target_path rather than staging_path. This change
corrects that mistake.

Also remove the extraneous "when possible" wording around when to supply
these fields.
Copy link
Member

@jdef jdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm mod CI

@saad-ali
Copy link
Member

/lgtm
/approve

@saad-ali saad-ali merged commit a33ece0 into container-storage-interface:master Oct 21, 2019
saad-ali added a commit that referenced this pull request Oct 21, 2019
@bswartz bswartz deleted the staging_path_fix branch December 30, 2019 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants