Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): allow dynamic java install #108

Merged
merged 7 commits into from
Aug 16, 2021
Merged

feat(java): allow dynamic java install #108

merged 7 commits into from
Aug 16, 2021

Conversation

viceice
Copy link
Member

@viceice viceice commented Aug 5, 2021

ref #16

closes #22

@viceice
Copy link
Member Author

viceice commented Aug 5, 2021

Curretnly only one version of v8, v11 and v16 is available. So i think we need to add the adopt api to renovate too.

@rarkins
Copy link
Member

rarkins commented Aug 5, 2021

I don't see any USER X changes here. Is it now installable as user instead of root?

@viceice
Copy link
Member Author

viceice commented Aug 5, 2021

I don't see any USER X changes here. Is it now installable as user instead of root?

Yes, need to update tests. 🤗

test/java/Dockerfile Outdated Show resolved Hide resolved
@viceice viceice marked this pull request as ready for review August 16, 2021 18:52
@viceice viceice enabled auto-merge (squash) August 16, 2021 18:52
@viceice viceice merged commit 2f3d203 into main Aug 16, 2021
@viceice viceice deleted the feat/dynamic-java branch August 16, 2021 19:00
@github-actions
Copy link

🎉 This PR is included in version 1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use adopt openjdk
2 participants